page = a few thoughts on cryptographic engineering – some …

url = https://blog.cryptographyengineering.com analysed @ 2022-01-14 20:16 UTC

If you already know what MetaMask does, skip this part.
Yet another dependency: this time to something called “
Update (1/14): the comments below discuss key generation in
, but MetaMask uses a BIP39-based keyphrase, which means that most ECDSA keys are actually generated elsewhere (allegedly in bitcoinjs/bip39 ). In retrospect this should have been obvious to me, but thanks to @kumavis_ for pointing it out. I’m keeping the section below just to be complete, but this code (probably) isn’t used by MetaMask.
A basic point to make here is that much of this review has come down to examining code that solves a single problem: (deterministically) sampling integers within a precise range. So far I’ve reviewed at least two different custom implementations of the same process, both with slightly different results. Why is the same code repeated so often? Just make this a subroutine so we can analyze it and be sure it’s working correctly.